virtme: let user disable KVM accel easily #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of duplicating the KVM check, pass whether it's okay to use KVM in from outside the arch code. Signed-off-by: Jakub Kicinski <[email protected]>
Some testers run without KVM support (including x86 testers running in nested VMs). Reproducing such conditions with vng currently requires a bit of hacking. Support --disable-kvm to do the same thing more cleanly. Signed-off-by: Jakub Kicinski <[email protected]>
|
Applied, thanks! I also like the fact that we rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --disable-kvm switch. Some of our testers run without KVM support (nested virt) and developers struggle to repro similarly sluggish execution for their tests. Allow turning KVM off with a single switch even when it's usable.