Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtme-ng: introduce -q/--quiet #59

Merged
merged 1 commit into from
Jan 31, 2024
Merged

virtme-ng: introduce -q/--quiet #59

merged 1 commit into from
Jan 31, 2024

Conversation

arighi
Copy link
Owner

@arighi arighi commented Jan 29, 2024

Introduce an option to nullify the effect -v/--verbose.

This option can be useful to override certain wrappers / aliases around vng, as pointed out in issue #58.

Introduce an option to nullify the effect -v/--verbose.

This option can be useful to override certain wrappers / aliases around
vng, as pointed out in issue #58.

Signed-off-by: Andrea Righi <[email protected]>
@jimc
Copy link
Contributor

jimc commented Jan 31, 2024

this looks right, but for some reason I cant install it to test.

[jimc@frodo virtme-ng]$ make
cd virtme_ng_init && cargo install --path . --root ../virtme/guest
Installing virtme-ng-init v0.1.0 (/home/jimc/projects/virtme-ng/virtme_ng_init)
Updating crates.io index
Finished release [optimized] target(s) in 0.32s
Replacing ../virtme/guest/bin/virtme-ng-init
Replaced package virtme-ng-init v0.1.0 (/home/jimc/projects/virtme-ng/virtme_ng_init) with virtme-ng-init v0.1.0 (/home/jimc/projects/virtme-ng/virtme_ng_init) (executable virtme-ng-init)
warning: be sure to add ../virtme/guest/bin to your PATH to be able to run the installed binaries

that last line is not right: ../guest/bin doesnt exist, anywhere under HOME,
more particularly, none of:

[jimc@frodo projects]$ ll -d virtme*
lrwxrwxrwx. 1 jimc jimc 10 Nov 18 19:43 virtme -> virtme.git
drwxrwxr-x. 1 jimc jimc 534 May 24 2023 virtme.git
drwxr-xr-x. 1 jimc jimc 474 Dec 28 07:46 virtme-ng
, has a guest/bin under it

the closest I can find is:
[jimc@frodo ~]$ find . -name guest
./.local/lib/python3.12/site-packages/virtme/guest
./projects/lx/virtme.git/build/lib/virtme/guest
./projects/lx/virtme.git/virtme/guest
./projects/lx/wk-next/builds/local-i915m/include/config/kvm/xfer/to/guest
./projects/virtme.git/build/lib/virtme/guest
./projects/virtme.git/virtme/guest
./projects/virtme-ng/virtme/guest
./projects/virtme-ng/build/lib/virtme/guest
[jimc@frodo ~]$ ll ./projects/virtme.git/virtme/guest
total 12
-rw-rw-r--. 1 jimc jimc 0 Nov 5 2020 init.py
drwxr-xr-x. 1 root root 48 Jan 16 2023 pycache
-rwxrwxr-x. 1 jimc jimc 7775 Mar 3 2021 virtme-init
-rwxrwxr-x. 1 jimc jimc 881 Nov 5 2020 virtme-udhcpc-script

@arighi
Copy link
Owner Author

arighi commented Jan 31, 2024

virtme-ng-init is installed in ./virtme/guest/bin inside the virtme-ng source dir. Also I never use make, it's there just to build virtme-ng-init. To build the whole virtme-ng I usually do BUILD_VIRTME_NG_INIT=1 pip install --break-system-packages .. This will install everything under your $HOME/.local so it can be done as regular user and it will override the system virtme-ng. Maybe I can add a make install target that does this...

@arighi arighi merged commit e2634de into main Jan 31, 2024
8 checks passed
@jimc
Copy link
Contributor

jimc commented Feb 1, 2024

Thanks!
vng -bv -q # works, is silent as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants