docker support #52
Merged
docker support #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide virtiofsd warnings that may confuse users, unless we are running in verbose mode. This fixes issue #51. Signed-off-by: Andrea Righi <[email protected]>
arighi
force-pushed
the
docker-support
branch
3 times, most recently
from
97f7c85 to
075f452
Compare
added 5 commits
December 21, 2023 16:06
Do not enable microvm or native kvm acceleration if /dev/kvm does not exist (or if we don't have permissions to use it). This may happen in container environments, despite running on a native architecture, but not having access to /dev/kvm may result in EPERM errors and warnings that may confuse users. This fixes issue #51. Signed-off-by: Andrea Righi <[email protected]>
Minor changes to our virtme-init script required to run virtme-ng instances inside docker containers. This fixes issue #51. Link: arighi/virtme-ng-init@6ed126b Signed-off-by: Andrea Righi <[email protected]>
Resync virtme-ng-init to apply the equivalent changes of commit b25a203 ("virtme-init: docker host support") also to virtme-ng-init. This fixes issue #51. Signed-off-by: Andrea Righi <[email protected]>
Add an example on how to use virtme-ng inside a docker container with an ubuntu-22.04 image. Moreover, add a note to the troubleshooting section, mentioning about the udev requirement to properly support stdin/stdout/stderr redirection with virtme-ng instances running inside docker. This fixes issue #51. Signed-off-by: Andrea Righi <[email protected]>
Now that we can properly run virtme-ng inside docker instances we can test virtme-ng using a github workflow. Add a simple "test run" workflow to run a v6.6 kernel using virtme-ng, this test action will be triggered on push and pull requests. Signed-off-by: Andrea Righi <[email protected]>
arighi
force-pushed
the
docker-support
branch
from
075f452 to
4ca6e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of changes to properly support running virtme-ng instances inside docker instances.
This will open the possibility for many projects to use virtme-ng to run custom kernels inside containerized environments, such as github workflows.
This fixes issue #51.