Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint warnings #163

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Fix lint warnings #163

merged 4 commits into from
Sep 29, 2024

Conversation

arighi
Copy link
Owner

@arighi arighi commented Sep 28, 2024

No functional change, just coding style cleanups to make lint happy.

Fix the following lint warnings:

 virtme/architectures.py:415:5: E303 too many blank lines (2)
 virtme/architectures.py:418:1: E305 expected 2 blank lines after class or function definition, found 1

Fixes: 4c81de7 ("virtme: architectures: Add "image" as s390x image name")
Signed-off-by: Andrea Righi <[email protected]>
Fix the following lint warning (\S in regex string interpreted as escape
sequence):

  virtme/commands/run.py:404:47: W605 invalid escape sequence '\S'

Fixes: 7b2f014 ("virtme: commands: run.py: Search for kernel version of the file name as fallback")
Signed-off-by: Andrea Righi <[email protected]>
Fix the following lint warning:

  virtme/cpiowriter.py:25:4: R0917: Too many positional arguments (13/5) (too-many-positional-arguments)

Signed-off-by: Andrea Righi <[email protected]>
Fix the following lint warnings:

 virtme/commands/run.py:665:0: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)
 virtme/commands/run.py:699:0: R0917: Too many positional arguments (7/5) (too-many-positional-arguments)

No functional change.

Signed-off-by: Andrea Righi <[email protected]>
@arighi arighi merged commit 18d08c7 into main Sep 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant