virtme: pass "debug" to the boot options when running in verbose mode #144
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some distro / kernels require the "debug" boot option to properly show the kernel messages to the console. Add this parameter to correctly show the kernel log when "-v" is used. This allows to properly show the kernel log in Arch Linux, CachyOS (and probably most of the Arch-derivative distro). Signed-off-by: Andrea Righi <[email protected]>
matttbe
reviewed
Jul 29, 2024
| @@ -1063,7 +1063,7 @@ def do_it() -> int: | |||
| qemuargs.extend(["-chardev", "file,path=/proc/self/fd/2,id=dmesg"]) | |||
| qemuargs.extend(["-device", arch.virtio_dev_type("serial")]) | |||
| qemuargs.extend(["-device", "virtconsole,chardev=dmesg"]) | |||
| kernelargs.extend(["console=hvc0"]) | |||
| kernelargs.extend(["console=ttyS0", "debug"]) | |||
There was a problem hiding this comment.
@arighi just to be sure, was the console= modification expected? I don't think that's an issue to switch to ttyS0, just surprised :)
|
@matttbe oops, it's totally a mistake, thanks for noticing it! Feel free to send a PR to restore it back to |
matttbe
added a commit
to matttbe/virtme-ng
that referenced
this pull request
Jul 29, 2024
It looks like it was accidentally modified [1]. The hypervisor console is supposed to be better, except to debug early console stuff. But that's OK, another serial is used for that: ttyS0 or ttyAMA0, depending on the arch. Fixes: 4bf382a ("virtme: pass "debug" to the boot options when running in verbose mode") Link: arighi#144 [1] Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some distro / kernels require the "debug" boot option to properly show the kernel messages to the console.
Add this parameter to correctly show the kernel log when "-v" is used.
This allows to properly show the kernel log in Arch Linux, CachyOS (and probably most of the Arch-derivative distro).