virtme-ng: more robust parsing of upstream versions

Checking if the target of `--run` begins with 'v' to determine if we need to run a pre-compiled upstream kernel is a bit too weak. For example we may incorrectly interpret files starting with 'v' as versions. Prevent this by using a proper regex to match for target versions. Signed-off-by: Andrea Righi <[email protected]>
arighi · Feb 22, 2024 · c164a3a · c164a3a
1 parent 58e1033
commit c164a3a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/virtme_ng/run.py b/virtme_ng/run.py
@@ -4,6 +4,7 @@
 """virtme-ng: main command-line frontend."""
 
 import argparse
+import re
 import os
 import sys
 import socket
@@ -800,7 +801,7 @@ def _get_virtme_run(self, args):
             # If an upstream version is specified (using an upstream tag) fetch
             # and run the corresponding kernel from the Ubuntu mainline
             # repository.
-            if args.run.startswith('v'):
+            if re.match(r'^v\d+(\.\d+)*$', args.run):
                 if args.arch is None:
                     arch = 'amd64'
                 else: