Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the scroll: update "active" entry in the sidebar #78

Merged
merged 2 commits into from
Apr 16, 2014

Conversation

jakub-g
Copy link
Collaborator

@jakub-g jakub-g commented Apr 15, 2014

This is part two of #52

@ymeine
Copy link
Contributor

ymeine commented Apr 15, 2014

I personally don't really like this kind of feature (or at least it should be a user preference if it could be so)

The thing is that when I'm reading an article, I often scroll past the end of the article, either to check quickly if there is something interesting after, or just to center the content vertically on my screen. So then I finish to read it, and want to share it. But crap, the URL changed!

Or also, sometimes I simply want to go back to the original anchor point that loaded the page, because I read a lot but don't want to scroll back. So I refresh the page, but the URL changed in the meantime...

@benouat
Copy link
Member

benouat commented Apr 15, 2014

I am a little bit puzzled by that one. I feel like @ymeine described.

I don't really see the need to have that one now that we have the sidebar that follow the scroll. If you want to share it, the link is just one click further...

So i would not go for that one. Sorry @jakub-g 😞

jakub-g added a commit to jakub-g/usermanual that referenced this pull request Apr 15, 2014
@jakub-g
Copy link
Collaborator Author

jakub-g commented Apr 15, 2014

Ok I see your point. I've updated the PR so it now changes the color in the menu of the "active" item instead of pushing the hash

usermanual--xx

@ymeine
Copy link
Contributor

ymeine commented Apr 15, 2014

Cool :)
Now next step: getting closer to gitbook :p

@jakub-g jakub-g changed the title Follow the scroll for the hash in the URL Follow the scroll: update "active" entry in the sidebar Apr 16, 2014
@jakub-g jakub-g merged commit 451d89a into ariatemplates:master Apr 16, 2014
@jakub-g jakub-g deleted the follow-the-scroll-hash branch April 23, 2014 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants