Add get_artifact for template invocator use
#1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
semver:minor
elliotgunton
changed the title
get_artifact for template invocator use
elliotgunton
force-pushed
the
add-get-artifact
branch
from
72e8ec5 to
52f85a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1284 +/- ##
=====================================
Coverage 86.1% 86.2%
=====================================
Files 60 60
Lines 4079 4089 +10
Branches 648 652 +4
=====================================
+ Hits 3516 3526 +10
Misses 392 392
Partials 171 171 ☔ View full report in Codecov by Sentry. |
elliotgunton
force-pushed
the
add-get-artifact
branch
3 times, most recently
from
d3cd835 to
016dc4e
Compare
* Similarly to `get_parameter`, allows subnodes like Tasks and Steps to "get" an artifact from the parent template (DAG or Steps) Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
* Tidy up Makefile targets * Add set-up-artifacts target to add minio storage from the argoproj-labs training materials Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
force-pushed
the
add-get-artifact
branch
from
016dc4e to
b4d8894
Compare
alicederyn
approved these changes
Dec 6, 2024
| raise KeyError(f"No artifacts set. Artifact {name} not found.") | ||
| for artifact in inputs.artifacts: | ||
| if artifact.name == name: | ||
| return Artifact(name=name, from_=f"{{{{inputs.artifacts.{artifact.name}}}}}") |
There was a problem hiding this comment.
Not sure why we're copying across all the fields in get_parameter, but only name in this function.
There was a problem hiding this comment.
We probably shouldn't copy everything in get_parameter, as all the other fields are irrelevant when used as an argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Adds
get_artifacttoIOMixinto allow tasks to get artifacts from the parent (DAG/Steps) template.Also added on-cluster test using Artifacts, which requires extra set up steps to add minio and configure it as the artifact repository.