Remove error override for default usage in Parameter annotations
#1278
+19
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotgunton
added
type:task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 60 60
Lines 4113 4102 -11
Branches 660 657 -3
=====================================
- Hits 3547 3538 -9
+ Misses 393 392 -1
+ Partials 173 172 -1 ☔ View full report in Codecov by Sentry. |
elliotgunton
changed the title
default usage in Parameter annotations
elliotgunton
force-pushed
the
remove-param-default
branch
from
8330349 to
a385a0b
Compare
alicederyn
approved these changes
Nov 27, 2024
sambhav
approved these changes
Nov 27, 2024
elliotgunton
force-pushed
the
remove-param-default
branch
from
61d27b9 to
e23e093
Compare
* You must now always use a Python default Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
Signed-off-by: Elliot Gunton <[email protected]>
elliotgunton
force-pushed
the
remove-param-default
branch
from
e23e093 to
94c4e36
Compare
elliotgunton
added
type:informational
elliotgunton
changed the title
default usage in Parameter annotationsdefault usage in Parameter annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Currently, when using the default attribute in Parameters (
Parameter(default="x")) users can supress the error with thesuppress_parameter_default_errorexperimental feature flag. If users have not updated their code (which is a very easy change) they will now get errors when upgrading Hera, the warning has been there for 2 minor versions and this is an experimental feature - we will be able to graduate it in the next version once this is released.