[BUGFIX] Redirect slash when defining ARGILLA_BASE_URL
#5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -171,7 +171,7 @@ def create_server_app() -> FastAPI: | |||
| # This if-else clause is needed to simplify the test dependency setup. Otherwise, we cannot override dependencies | |||
| # easily. We can review this once we have separate fastapi application for the api and the webapp. | |||
| if settings.base_url and settings.base_url != "/": | |||
| _app = FastAPI(docs_url=None, redoc_url=None, openapi_url=None, redirect_slashes=False) | |||
| _app = FastAPI(docs_url=None, redoc_url=None, openapi_url=None, redirect_slashes=True) | |||
There was a problem hiding this comment.
Great! I think this has been the culprit for some of the HF Space errors.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5796 +/- ##
===========================================
- Coverage 91.97% 91.94% -0.04%
===========================================
Files 161 161
Lines 6928 6927 -1
===========================================
- Hits 6372 6369 -3
- Misses 556 558 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Nice! This should help out @aleksvercau |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5792
Type of change
How Has This Been Tested
Checklist