Feat/props #60
Merged
Feat/props #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sceat
approved these changes
Jan 7, 2025
|
/merge |
|
Unable to merge, is this PR ready and approved ? |
Compute them in view space to avoid floating precision issues
The stock threejs frustum culling works but does not take distance into account (since the frustum distance is way greater than the props view distance). So, complete this frustum culling by manually hiding batches that are too far to be seen.
Sceat
approved these changes
Jan 7, 2025
|
/merge |
|
Success! Fast forwarded master to feat/props! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new class
PropsViewerin the engine that will be used to display ground clutter (grass, rocks for instance).It does so by using instancing which allows rendering of 10000s of props with great performance.
Also, adds support to make the grass react to the player.