Feat: add support for advanced lighting and shadows #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a custom shader since the geometry is created in the vertex shader, which is not supported by the default THREEjs shadow shaders
This works by customizing three.js's MeshPhongMaterial. Will also allow specularity, fog etc.
Because now the terrain reacts to the three.js lights added to the scene, like any other object.
piellardj
changed the title
Sceat
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
MeshPhongShader, which means that the Terrain now behaves as any other mesh in the scene: it reacts to scene lights, has support for specularity etc.Here is an illustration of the terrain casting and receiving shadows:
