Feat/optimizations #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only compute patches that are sure to be within the visibility sphere
Don't even ask for patches that are out of bounds
This allows to free GPU memory when there are too any invisible patches. An invisible patch is a patch that was computed once and then went invisible because it is out of sight.
Sceat
requested changes
Mar 25, 2024
Sceat
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains various fixes and optimizations of the way the GPU memory is handled:
Terrain.showMapAroundPosition()is now more strict now, and only shows patches that will be visible for sureTerrainnow removes from GPU memory patches that have been invisible for a long time. As a reminder, a patch can become invisible if it was computed once and then went out of sight because the player moved. The size of this LRU cache is configurable with the newTerrain.patchesCacheSizeattributesetVerbositymethod.