fc: adjust overscan numbers #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am happy to accept the overscan changes in this PR However, I would like to keep the blanking of the sides and top in PAL regions, though. My reasoning here is that while overscan is a property of the display and is subjective, the blanking of the top 1px, left 2px, and right 2px is an actual behaviour of the PAL PPU and is not subjective; there is no way real hardware would ever display these lines regardless of overscan/scaling. if you want to keep the pixel aspect ratio/screenshot size the same, I'm happy for those lines to be left black, but I hold firm that we should keep them emulated, as this is how the PPU behaves. |
|
Yeah I had a feeling you'd say that. It would be nice to have a toggle for this in the video section at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overscan=off now shows active display centered and intact for both regions. The pal ppu micromasking behavior was corrected (253 vs 254) and commented out.
SMB2 EUR full frame
before/after
before/after
