Updates/fixes to the driver, works at NSLS2 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code to be remove because it is not being used and confuses the reader
…in the last commit. Cleaned printfs and fixed ADStatus update to the parent.
…tosettings.req to look the same as for other detectors, now that mythen.req is gound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have finally got hands on another Mythen unit and tried #4. It compiles but did not work for me. Many standard PVs were red, and I could not acquire.
The changes in this PR makes all standard PVs accessible, and one can acquire an image (spectra actually).
The changes needs clean up at least from my personal comments, if considered for merging, and quite possible something else.
I would need to add one more feature for this beamline. They have a 24 channel unit which is programmed (by Dectris) to use 5 modules. They have only 3. In order for everything to work, one needs to set the actual number of connected modules . Currently I use Dectris web client for this.
The changes in this PR were done some time ago for another beamline with 1 Channel Mythen.
Also, while I am around this unit, I can work on the documentation. Not sure how start though.