Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel compiling: arduino-builder will leverage your multi core pc #242

Closed
wants to merge 2 commits into from

Conversation

copercini
Copy link
Contributor

@copercini copercini commented Aug 14, 2017

If -jobs X param is specified and X is greater than 0, arduino-builder won't spawn more than X processes. Fixes #17

If -jobs X param is specified and X is greater than 0, arduino-builder won't spawn more than X processes. Fixes arduino#17

- Rebased from Federico Fissore branch arduino@0a3d888#diff-8f074e2b3fc911dbe8255891fc1a9b13R96
- Add HumanTagsLogger compatibility
- Remove an if which suppress some GCC error messages here: arduino@0a3d888#diff-8f074e2b3fc911dbe8255891fc1a9b13R96
Parallel compiling: arduino-builder will leverage your multi core pc
@copercini
Copy link
Contributor Author

copercini commented Aug 14, 2017

Compilation time benchmarks (Based on Travis CI builds )

benchmark compilation time

@facchinm
Copy link
Member

@ArduinoBot build this please

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-242.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-242.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@matthijskooijman
Copy link
Collaborator

@copercini, I couldn't manage to reproduce the slowness of the PR236 build (see #236 (comment)). Any chance that was just a measurement error on your side (system under load perhaps)? Could you see if you can reproduce this slowness again?

@copercini
Copy link
Contributor Author

@matthijskooijman The data used in the table comes from this build: https://travis-ci.org/arduino/arduino-builder/builds/243798460
In the new builds of #236 like https://travis-ci.org/arduino/arduino-builder/builds/309526510 the compilation time is similar to others PRs, so everything looks normal

So yes, probably the slowness comes from something in Travis CI just at this time and your PR is fine

@matthijskooijman
Copy link
Collaborator

Thanks for checking!

@kubark42
Copy link

This seems useful. Especially on Windows, where Arduino seems to build more slowly on a 2018 Surface Book 2 than a 2014 Macbook Pro. @copercini was there a blocker?

@cmaglie
Copy link
Member

cmaglie commented May 31, 2018

This one has been manually merged.

@cmaglie cmaglie closed this May 31, 2018
@cmaglie cmaglie added this to the 1.3.26 milestone May 31, 2018
@PaulStoffregen
Copy link

Any chance for a 1.8.6 release with this feature?

I've been using 1.8.5 with 1.9's builder and preprocessor, and the new preprocessor rule added to 1.8.5's platform.txt. It's really awesome for larger projects with a lot of code!

I'm sure much of the Arduino community would love a near-term stable 1.8.6 release with this feature....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants