F: Adds versions and upgrade tests to the contracts #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosgj94
requested changes
Feb 17, 2025
|
|
||
| # Notes from the Halborn Audit | ||
|
|
||
| https://www.halborn.com/portal/reports/ve-governance-updates |
There was a problem hiding this comment.
Externals can't get this link. Let's change it directly to the one we are uploading in this PR.
f: adds support for forge 1.0.0 in test cases
F/regression test
Poc/versioned tests
jordaniza
changed the title
novaknole
reviewed
Feb 20, 2025
| // voter.upgradeTo(address(voterV1_1_0)); | ||
|
|
||
| // safe upgrade | ||
| _safeUpgradeVoter(address(voter)); |
There was a problem hiding this comment.
I'd still use upgradeTo instead of upgradeProxy helper. The reason being is in the actual upgrade, we don't use upgradeProxy. To keep things as close as possible, both the tests and the actual upgrade must follow the same flow.
Storage compatibility can still be tested without upgradeProxy.
There was a problem hiding this comment.
that's a fair point. Ideally we'd use a single upgrade factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.