Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add script to merge all proposal actions #641

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Feat: add script to merge all proposal actions #641

wants to merge 38 commits into from

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Feb 6, 2025 •
edited
Loading

Description

  • create a script to merge all plugin json actions and the calldata for the proposal creation
  • add tests to simulate the proposal creation, approvals and execution
  • upgrade the SDK version to use the latest one

=============== NOTE: do not merge until changing the .only for .skip ===============

Task ID: OS-1569

Type of change

See the framework lifecycle in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.
  • I have created a follow-up task to update the Developer Portal with the changes made in this PR.

brickpop
brickpop previously requested changes Feb 10, 2025
View reviewed changes
@clauBv23 clauBv23 force-pushed the feat/add-script-to-merge-all-proposal-actions branch from 2fe5572 to cccd6af Compare February 12, 2025 13:17
@brickpop brickpop force-pushed the feat/add-script-to-merge-all-proposal-actions branch from 594d827 to cc0d964 Compare February 12, 2025 14:55
@clauBv23 clauBv23 requested a review from brickpop February 13, 2025 11:13
brickpop
brickpop reviewed Feb 28, 2025
View reviewed changes
packages/contracts/scripts/management-dao-proposal/generate-managing-dao-proposal-info.ts

const deployedContractsRaw = fs.readFileSync(deployedContractsPath, 'utf-8');
// load the osx deployed contracts
const deployedContracts = JSON.parse(deployedContractsRaw);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has no typing and no data checks. This can produce unexpected behaviour.

@aragon aragon deleted a comment from brickpop Feb 28, 2025
@Rekard0 Rekard0 dismissed brickpop’s stale review February 28, 2025 23:02

We have solve all, original PR creator is not working on the PR anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brickpop brickpop brickpop left review comments

@Rekard0 Rekard0 Rekard0 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clauBv23 @brickpop @Rekard0