Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test audit merge #637

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Test audit merge #637

merged 2 commits into from
Feb 4, 2025

Conversation

novaknole
Copy link
Contributor

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task: ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

novaknole and others added 2 commits January 20, 2025 14:27
@novaknole @Rekard0
add update to 1.4.0 (#627)
d8222db 
* add update to 1.4.0

* add tests

* remove ens

* add upgrades for daoregistry+pluginreporegistry

* comment

* Update packages/contracts/deploy/update/to_v1.4.0/31_DAORegistry.ts

Co-authored-by: Rekard0 <[email protected]>

* add verification for registry implementations

* remove zk from git

---------

Co-authored-by: Rekard0 <[email protected]>
@novaknole @clauBv23
Zksync (#629)
8968d25 
* add wrapper class and hardhat config

* remove comment

* add more tests

* more tests

* add more tests

* fix bugs

* fix more things

* fix

* fix psp tests

* add more fixes

* close fork

* feat: add zksync network and update the deploy scripts path

* env example typo

---------

Co-authored-by: Claudia <[email protected]>
@novaknole novaknole merged commit feca06c into audit-20241118 Feb 4, 2025
28 of 65 checks passed
@novaknole novaknole deleted the test-audit-merge branch February 4, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@novaknole