Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add changelog #631

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Feat/add changelog #631

merged 3 commits into from
Feb 3, 2025

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented Jan 22, 2025

Description

  • Add change on changelog saying that ENS is optional on both the dao and the plugins
  • Export the DAOStructs with the ActionStruct in osx-ethers

Task: OS-1560, OS-1512,

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.

@novaknole novaknole merged commit e77f489 into develop Feb 3, 2025
3 of 17 checks passed
@novaknole novaknole deleted the feat/add-changelog branch February 3, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants