add comment

aragon · Feb 28, 2025 · 83dd772 · 83dd772
1 parent e339c95
commit 83dd772
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/contracts/scripts/management-dao-proposal/README.md b/packages/contracts/scripts/management-dao-proposal/README.md
@@ -45,6 +45,14 @@ This will generate two files in the `./generated` folder:
 - A `merged-proposals.json` file with all the proposal and deployment details
 - A `calldata.json` file with the proposal information and the raw calldata
 
+## Testing the calldata
+
+Once all the files are in place:
+
+- Add `RUN_UPGRADE_1_4_0_TESTS_AT_FORK_BLOCK` to the .env and set a fork block, it is recommended to use a recent block.
+- Run `yarn test`.
+  This will test the call data and simulate the proposal creation and execution.
+
 ## Steps
 
 1. Deploy the framework

diff --git a/packages/contracts/test/deploy/deployment-1.4.0.ts b/packages/contracts/test/deploy/deployment-1.4.0.ts
@@ -438,8 +438,6 @@ if (process.env.RUN_UPGRADE_1_4_0_TESTS_AT_FORK_BLOCK) {
       tx = await multisig.execute(proposalId);
       receipt = await tx.wait();
 
-      // todo think on a way to parse all events or if it is worthy
-
       // check the proposal is executed
       proposal = await multisig.getProposal(proposalId);
       expect(proposal.executed).to.be.true;