Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed execution details from plugin actions #7

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

jordaniza
Copy link

Description

Removes execution data from actions inside proposals. Adds manual testing that can be replicated inside other plugins then refactored.

An ID for generating actions has been created, this will be moved to the osx-commons-subgraph.

https://www.notion.so/aragonorg/execResult-in-the-Subgraph-8879407b1d6f42f19530ef6bc06b3dc6#da8cb903e33342279d88725f068c9506

Task ID: OS-1162

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

@jordaniza jordaniza marked this pull request as draft March 27, 2024 15:10
@jordaniza jordaniza marked this pull request as ready for review April 2, 2024 15:50
@jordaniza jordaniza merged commit 51d013e into develop Apr 2, 2024
5 checks passed
@novaknole novaknole deleted the f/split-subgraph-actions branch November 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants