F/rinkeby to goerli #1783
Merged
F/rinkeby to goerli #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mathewmeconry
commented
Oct 12, 2022
mathewmeconry
commented
- Removes rinkeby references
- Adds goerli support
Barukimang
reviewed
Oct 12, 2022
There was a problem hiding this comment.
@mathewmeconry don't mind me nosing in this, was just curious :) Question: the Rinkeby 'registry' address in arapp.json hasn't been edited, can it stay the same for Goerli?
mathewmeconry
added a commit
that referenced
this pull request
Oct 13, 2022
mathewmeconry
added a commit
that referenced
this pull request
Oct 21, 2022
* fix: switches mumbai rpc to our alchemy node (#1769) * fix: update web3.js and wrapper (#1779) * F/rinkeby to goerli (#1783) * feat: removes rinkeby and adds goerli * fix: makes the linter happy * Dtech patch 1 - helpscout to hubspot (#1786) * adding hubspot and removing helpscout using this documentation https://developers.hubspot.com/docs/api/conversation/chat-widget-sdk to replace the help widget * hubspot code needed to be in the head * back to right before the body for best practices Co-authored-by: alibama <[email protected]>
mathewmeconry
added a commit
that referenced
this pull request
Apr 12, 2023
* fix: switches mumbai rpc to our alchemy node (#1769) * fix: update web3.js and wrapper (#1779) * F/rinkeby to goerli (#1783) * feat: removes rinkeby and adds goerli * fix: makes the linter happy * Dtech patch 1 - helpscout to hubspot (#1786) * adding hubspot and removing helpscout using this documentation https://developers.hubspot.com/docs/api/conversation/chat-widget-sdk to replace the help widget * hubspot code needed to be in the head * back to right before the body for best practices * fix: changes goerli ENS registry to the correct address (#1790) * Feature/jira widget2 (#1809) * Changed the DAI address to the official Rinkeby Compound DAI address This address does have liquidity on Rinkeby Uniswap unlike the former one * Update Dandelion info * Update Dandelion info2 * fixing error with yarn lint --fix * comma fix * created tag for unsupported and added it to dandelion index * added unsupported tag logic to templatedetails * added unsupported tag to fundraising template and fixed link * removed survey app from discover apps * added unsupported tag to open-enterprise template * added unsupported tags in descover apps and removed survey icon import * edited unsupported tags to not maintained * wallet-connect appearing in connect account box * added walletconnect_url logic * added other chains next to eth-mainnet for wallet-connect * fixed failing test on prettier error * disabled if not statement walletconnect_url variable * added rpc data to walletconnect * removed unessecary walletconnect_url logic * removed unessecary instance * fixed prettier issue * removed unnecessary secret * updated rpc-endpoints to aragon-rpc-endpoints * disabled buggy and unused networks for network selection modal * replaced hubspot beacon with jira widget * undid changes to network-config.js which are part of another to be reviewed pr * fix: merge fail for goerli eth registry --------- Co-authored-by: alibama <[email protected]> Co-authored-by: Barukimang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.