Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add data to proposal actions json #39

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

clauBv23
Copy link

@clauBv23 clauBv23 commented Feb 6, 2025

Description

  • add the proposal action calldata to the json file generated when publishing the new version

Task ID: OS-?

Type of change

See the framework lifecylce in packages/contracts/docs/framework-lifecycle to decide what kind of change this pull request is.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have updated the DEPLOYMENT_CHECKLIST file in the root folder.
  • I have updated the UPDATE_CHECKLIST file in the root folder.
  • I have updated the Subgraph and added a QA URL to the description of this PR.

Rekard0
Rekard0 previously approved these changes Feb 18, 2025
brickpop
brickpop previously approved these changes Feb 18, 2025
@clauBv23 clauBv23 dismissed stale reviews from brickpop and Rekard0 via 19a3a44 February 18, 2025 16:10
@clauBv23 clauBv23 requested review from brickpop and Rekard0 February 18, 2025 16:10
@Rekard0 Rekard0 merged commit dc6c9c6 into main Feb 18, 2025
5 of 7 checks passed
@Rekard0 Rekard0 deleted the feat/add-data-to-proposal-actions-json branch February 18, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants