Compare to audit branch for new changes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: update to use upload to pinnata
…setup Add missing SET_TARGET_CONFIG_PERMISSION_ID to the setup
… into feature/zksync
Feature/zksync
brickpop
reviewed
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure that:
Adminplugin can be deployed on ZkSync. SinceAdminSetupwas usingclones, it's not possible to deploy on ZkSync. SoAdminSetupZkSynctakes care of this. Note thatAdmincontract was usinginitialize(upgradability pattern), so to avoid lots of confusion(since we don't want Admin to be upgradeable), we had to create azksync/Adminto take care of it.We added one more permission grant in the setup.