feat: update Oracle tracker to store advisory ID (ELSA ID) in database #484
+108
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
santhosh1729
commented
Jan 19, 2025
santhosh1729
commented
- Modify Oracle tracker to include logic for saving advisory IDs (ELSA IDs) in the database.
- Modify Oracle tracker to include logic for saving advisory IDs (ELSA IDs) in the database.
There was a problem hiding this comment.
Hello @santhosh1729
Thanks for your work!
We are worried about size of trivy-db.
Can you check and write actual and new sizes for DBs?
Also i left 1 comment, take a look, please.
| for k, v := range latestVersions { | ||
| versionToArches[v] = append(versionToArches[v], k.Arch) | ||
| adv := versionToArches[v.FixedVersion] | ||
| adv.VendorIDs = v.VendorIDs |
There was a problem hiding this comment.
It can be wrong for case when 2 advisories with same fixedVersion got from 2 different ELSA-IDs
e.g.
- ELSA-xxxx-0001 - fixedVersion == 0.0.1, arch == amd64
- ELSA-xxxx-0002 - fixedVersion == 0.0.1, arch == aarch64
for this case entry will include only one ELSA-xxxx-0002 (or 0001)
There was a problem hiding this comment.
perhaps we need to create 2 different entries for this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.