ci: enable strict mode by default in opa check #319
+86
−383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
force-pushed
the
strict-mode
branch
from
0d39c73 to
86696cc
Compare
nikpivkin
commented
Jan 16, 2025
| @@ -24,6 +24,13 @@ jobs: | |||
| - name: Checkout code | |||
| uses: actions/checkout@v4 | |||
|
|
|||
| - uses: actions/setup-go@v5 | |||
There was a problem hiding this comment.
regal recommends running opa check before linting.
simar7
reviewed
Jan 16, 2025
Comment on lines
-64
to
+63
| "Egress" in input.spec.policyType | ||
| "Egress" in spec.policyType |
There was a problem hiding this comment.
Just used the spec argument which is equal to input.spec.
simar7
reviewed
Jan 16, 2025
Comment on lines
+46
to
+48
| roleBindingKinds := {"RoleBinding", "ClusterRolebinding"} | ||
|
|
||
| is_role_binding_kind if kind in roleBindingKinds |
There was a problem hiding this comment.
Yes, it was in a few places and I thought it might be reused:
- https://github.com/aquasecurity/trivy-checks/blob/main/checks/kubernetes/general/masters_group_bind.rego#L31
- https://github.com/aquasecurity/trivy-checks/blob/main/checks/kubernetes/gke/authenticate_group_bind.rego#L31
- https://github.com/aquasecurity/trivy-checks/blob/main/checks/kubernetes/general/anonymous_user_bind.rego#L30
Signed-off-by: Nikita Pivkin <[email protected]>
Signed-off-by: Nikita Pivkin <[email protected]>
Signed-off-by: Nikita Pivkin <[email protected]>
Signed-off-by: Nikita Pivkin <[email protected]>
Signed-off-by: Nikita Pivkin <[email protected]>
nikpivkin
force-pushed
the
strict-mode
branch
from
86696cc to
18d910a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OPA 1.0, some strict mode checks will be enabled by default. See https://www.openpolicyagent.org/docs/latest/v0-upgrade/ and open-policy-agent/opa#6271 . This PR includes a strict mode now.