Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CIS EKS 1.5.0 #1653

Merged
merged 10 commits into from
Jan 10, 2025
Merged

feat: CIS EKS 1.5.0 #1653

merged 10 commits into from
Jan 10, 2025

Conversation

pbalogh-sa
Copy link
Contributor

@pbalogh-sa pbalogh-sa commented Aug 5, 2024

This PR adds CIS EKS 1.5.0 support for kube-bench.
Related issue: #1620

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2024

CLA assistant check
All committers have signed the CLA.

@mozillazg mozillazg self-requested a review August 18, 2024 08:41
Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some comments. Please check them when you get a chance. Thanks!

cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
cfg/eks-1.5.0/node.yaml Outdated Show resolved Hide resolved
@mozillazg
Copy link
Collaborator

@pbalogh-sa Sorry for the delayed review.

@mozillazg
Copy link
Collaborator

@pbalogh-sa Could you please help to update https://github.com/aquasecurity/kube-bench/blob/main/docs/platforms.md and https://github.com/aquasecurity/kube-bench/blob/main/docs/architecture.md ? Thanks!

@pbalogh-sa
Copy link
Contributor Author

@mozillazg Sorry for the late answer. I've updated the PR, please check again.

Copy link
Collaborator

@mozillazg mozillazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@mozillazg mozillazg requested a review from afdesk January 9, 2025 14:36
Copy link
Collaborator

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbalogh-sa thanks for the contribution!
lgtm!

@afdesk
Copy link
Collaborator

afdesk commented Jan 10, 2025

@mozillazg thanks a lot for the review!

@afdesk afdesk merged commit a38a3c5 into aquasecurity:main Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants