This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: Fix list-objects check for common-prefixes #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a list-objects issue that happened when calculating if a query should be truncated or not when having common prefixes. The proposed code change is using the last valid entry (entry being either the last object name or common prefix) as the next marker for the call that checks if there are more items. That way we are taking into account items that were already added to the results and we're not repeating them. (Also the truncation is calculated fine). Fixes: https://github.com/aquarist-labs/s3gw/issues/838 Signed-off-by: Xavi Garcia <[email protected]>
jecluis
approved these changes
Dec 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a list-objects issue that happened when calculating if a query should be truncated or not when having common prefixes.
The proposed code change is using the last valid entry (entry being either the last object name or common prefix) as the next marker for the call that checks if there are more items.
That way we are taking into account items that were already added to the results and we're not repeating them. (Also the truncation is calculated fine).
PR also adds a new integration test similar to the one reported in the bug and verifies that the list-objects call was not truncated.
Fixes: https://github.com/aquarist-labs/s3gw/issues/838
Signed-off-by: Xavi Garcia [email protected]
Checklist