This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: fail gracefully if objref not created #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecluis
added
kind/bug
tserong
previously approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Looks sensible to me.
Also, amusingly, I wrote a comment in fsck.sfs last week which said this once picked up a ".m" file, which is a combined multipart upload temp file, prior to it being moved to the final object. No idea how I managed to hit that - it should be really difficult... so I guess I hit one of these failure points in the past, but since your third commit to clean that stuff up, suspect I won't hit it again :-)
irq0
previously approved these changes
Nov 23, 2023
irq0
previously approved these changes
Nov 23, 2023
jecluis
dismissed
irq0’s stale review
The merge-base changed after approval.
irq0
previously approved these changes
Nov 23, 2023
jecluis
dismissed
irq0’s stale review
The merge-base changed after approval.
irq0
previously approved these changes
Nov 23, 2023
jecluis
dismissed
irq0’s stale review
The merge-base changed after approval.
It may happen if we conflict in-flight with another thread. Ensure we just fail gracefully to the client. Fixes: aquarist-labs/s3gw#820 Signed-off-by: Joao Eduardo Luis <[email protected]>
Signed-off-by: Joao Eduardo Luis <[email protected]>
Signed-off-by: Joao Eduardo Luis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may happen if we conflict in-flight with another thread. Ensure we
just fail gracefully to the client.
Additionally, remove dangling final multipart build files.
Fixes: aquarist-labs/s3gw#820
Signed-off-by: Joao Eduardo Luis <[email protected]>