This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
rgw/sfs: Use sqlite3_status() in make_sqlite3_status_fn() #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irq0
previously approved these changes
Oct 18, 2023
tserong
force-pushed
the
wip-metrics-use-sqlite3_status
branch
from
ee79aba to
d00b71b
Compare
|
(force push was just to fix signature) |
tserong
force-pushed
the
wip-metrics-use-sqlite3_status
branch
from
d00b71b to
07047d0
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
The current implementation calls sqlite3_db_status(), which is incorrect, given we're using it for SQLITE_STATUS_MEMORY_USED, SQLITE_STATUS_MALLOC_SIZE, and SQLITE_STATUS_MALLOC_COUNT. These codes are for use with sqlite3_status(). Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-metrics-use-sqlite3_status
branch
from
07047d0 to
42a0575
Compare
irq0
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation calls sqlite3_db_status(), which is incorrect, given we're using it for SQLITE_STATUS_MEMORY_USED, SQLITE_STATUS_MALLOC_SIZE, and SQLITE_STATUS_MALLOC_COUNT. These codes are for use with sqlite3_status().