Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(a-h/templ): cosign config #32935

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

scop
Copy link
Contributor

@scop scop commented Mar 6, 2025

https://github.com/a-h/templ/releases

https://github.com/a-h/templ/blob/main/docs/docs/10-security/03-code-signing.md

I did not have luck verifying releases < 0.2.639, which was the first version where cosign.pub was in the repo.

Check List

@@ -1,8 +1,10 @@
packages:
- name: a-h/[email protected]
- name: a-h/templ
version: v0.0.153
version: v0.2.639
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test data doesn't match with the version constraint.

- version_constraint: semver("< 0.2.639")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Mistake when manually bisecting first working version. Fixed in bb1a822

@suzuki-shunsuke
Copy link
Member

Thank you always!

@suzuki-shunsuke suzuki-shunsuke added this to the v4.324.2 milestone Mar 6, 2025
@suzuki-shunsuke suzuki-shunsuke merged commit d53745b into aquaproj:main Mar 6, 2025
17 checks passed
@suzuki-shunsuke
Copy link
Member

@scop scop deleted the feat/templ-cosign branch March 9, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants