Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved navbar style on different pages and improved navigation/redi… #1671

Merged

Conversation

jitendrasuthar1998
Copy link
Contributor

…rection flow

Title and Issue number

Title : Navbar styling is not consistent across all pages

Issue No. #1626

Close #1626

Description

  1. Made navbar style consistent on different pages
  2. Improved navigation flow on different pages

Video/Screenshots (mandatory)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under KWOC 2024

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 36e8fee
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/676ef20fafe8d50008be343c
😎 Deploy Preview https://deploy-preview-1671--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jitendrasuthar1998 jitendrasuthar1998 changed the title Improved navbar style on different pages and improved navigation/redi… fix: Improved navbar style on different pages and improved navigation/redi… Dec 26, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

All of the changes u have made are really good , but through the changes u have made this button is misaligned , please try to fix this as its original place , so try to fix it so that i can merge this pr

@apu52 apu52 added the help wanted Extra attention is needed label Dec 27, 2024
@jitendrasuthar1998
Copy link
Contributor Author

@apu52 Ohk. I will align button and then update PR.

@jitendrasuthar1998
Copy link
Contributor Author

@apu52 I have done the required changes.

image

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jitendrasuthar1998 really great work , Thanks for your valuable contribution

@apu52 apu52 merged commit f2f2eca into apu52:main Dec 27, 2024
5 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1671 has been merged! 🎉🎉

@apu52 apu52 added KWOC and removed help wanted Extra attention is needed labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar styling is not consistent across all pages
2 participants