Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fevicon not visible on all html pages #1431 #1540

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

CharVaibhav
Copy link
Contributor

@CharVaibhav CharVaibhav commented Oct 20, 2024

Fevicon not visible on all html pages #1431

Title : Fevicon not visible on all html pages

Issue No. : 1431

Close #1431

Description

Added missing favicon to html pages below:

  1. 404
  2. about
  3. contributors
  4. HoneyMoon
  5. Licensing
  6. newLogin
  7. packages
  8. Signup
  9. thankyou
  10. tnc
  11. topdeal

Video/Screenshots (mandatory)

Screenshot 2024-10-20 144928
Screenshot 2024-10-20 144948

(AND OTHERS)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Added missing favicon to html pages below:
1. 404
2. about
3. contributors
4. HoneyMoon
5. Licensing
6. newLogin
7. packages
8. Signup
9. thankyou
10. tnc
11. topdeal
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 4984933
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6714cbdd29722c00089cafa7
😎 Deploy Preview https://deploy-preview-1540--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CharVaibhav! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@CharVaibhav CharVaibhav changed the title #1431 Fevicon not visible on all html pages #1431 Oct 20, 2024
@CharVaibhav CharVaibhav changed the title Fevicon not visible on all html pages #1431 fix: Fevicon not visible on all html pages #1431 Oct 20, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharVaibhav okk got it

@apu52 apu52 merged commit f72c937 into apu52:main Oct 26, 2024
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fevicon not visible on all html pages
2 participants