Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #133

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Upgrade dependencies #133

merged 3 commits into from
Oct 27, 2023

Conversation

lkct
Copy link
Member

@lkct lkct commented Oct 27, 2023

  • Updated pyproject.toml:
    • Python 3.12 added to support list -- should be automatically compatible given dependencies available in 3.12.
    • Dependency versions:
      • torch fixed to ~=2.1.0. we should manually upgrade.
      • mypy fixed to ==1.6.1. minor version also affects typing, so we need exact version.
      • pylint fixed to ~=3.0.0. we should manually upgrade when need to (e.g. bugfixes).
      • pydocstyle fixed to ~=6.3.0. this does not upgrade much and 6.3.0 should be enough.
    • Linting rules:
      • isort target updated to 3.8. previously it's 3.9, which was a typo.
      • pylint updated according to API change, enabled new prefer-typing-namedtuple.
      • mypy sorted according to docs. enabled new possibly-undefined.
  • Updated code:
    • PR Fix mypy errors #128 partially reverted -- removed the temp fix for mypy 1.5 upstream bug.
    • Fixed other bugs arising from the version change.
    • Fixed some cyclic import -- previously inconsistent on CI and local.

@lkct lkct self-assigned this Oct 27, 2023
@lkct lkct added the repository Related to managing the repository label Oct 27, 2023
@lkct lkct merged commit 9fadcda into main Oct 27, 2023
@lkct lkct deleted the deps-upgrade branch October 27, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository Related to managing the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant