Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditinally setting href for sign-in #151

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conditinally setting href for sign-in #151

merged 3 commits into from
Jul 9, 2024

Conversation

SayedTahsin
Copy link
Contributor

No description provided.

Signed-off-by: SayedTahsin <[email protected]>
@SayedTahsin SayedTahsin requested review from mohin7 and nurRiyad July 8, 2024 11:43
Copy link

github-actions bot commented Jul 8, 2024

Visit the preview URL for this PR (updated for commit 4857c07):

https://appscode-v3-hugo--pr151-tahsin-signinurl-8jpopbsh.web.app

(expires Mon, 15 Jul 2024 12:39:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1720b7810a846fabdac7ca3b944d0f3a577e94de

mohin7
mohin7 previously approved these changes Jul 8, 2024
Copy link
Member

@mohin7 mohin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nurRiyad
nurRiyad previously approved these changes Jul 8, 2024
@mohin7 mohin7 requested a review from tamalsaha July 8, 2024 11:50
Signed-off-by: SayedTahsin <[email protected]>
@SayedTahsin SayedTahsin dismissed stale reviews from nurRiyad and mohin7 via 4857c07 July 8, 2024 12:35
@tamalsaha tamalsaha merged commit e1541c9 into master Jul 9, 2024
7 checks passed
@tamalsaha tamalsaha deleted the tahsin/signinUrl branch July 9, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants