Skip to content

Commit

Permalink
Remove some TODO's
Browse files Browse the repository at this point in the history
  • Loading branch information
vishesh committed Aug 19, 2023
1 parent 69ca513 commit 439c6a1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
8 changes: 1 addition & 7 deletions Sources/ARTreeModule/ARTree.swift
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,16 @@
//===----------------------------------------------------------------------===//

// TODO:
// * Check deallocate of nodes.
// * Path compression when deleting.
// * Range delete.
// * Delete node should delete all sub-childs (for range deletes)
// * Confirm to Swift Dictionary/Iterator protocols.
// * Fixed sized array.
// * Confirm to Swift dictionary protocols.
// * Generic/any serializable type?
// * Binary search Node16.
// * SIMD instructions for Node4.
// * Replace some loops with memcpy.
// * Better test cases.
// * Fuzz testing.
// * Leaf don't need to store entire key.
// * Memory safety in Swift?
// * Values should be whatever.

public struct ARTree<Value> {
var root: RawNode?

Expand Down
4 changes: 2 additions & 2 deletions Sources/ARTreeModule/Node.swift
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ extension RawNode {
}

protocol ManagedNode: NodePrettyPrinter {
var storage: NodeStorage<Self> { get }
static func deinitialize<N: ManagedNode>(_ storage: NodeStorage<N>)

static var type: NodeType { get }

var storage: NodeStorage<Self> { get }
var type: NodeType { get }
var rawNode: RawNode { get }
}
Expand Down

0 comments on commit 439c6a1

Please sign in to comment.