Permit Time class loading from YAML.
#81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Psych 4.0, the `safe_load` is used as default loading mechanism. There are just a few permitted classes and `Time` is not one of them [[1]]. This results it test failure: ~~~ Error: test_converting_to_yaml(DocumentTest::TestSimpleConventionallyNamedDocument): Psych::DisallowedClass: Tried to load unspecified class: Time ~~~ Please also note that in YAML specs 1.2, the `timestamp` is not listed as supported tag anymore [[2]]. Given that: 1) ronn-ng does not provide any supported way of loading the serialized YAML. 2) The `to_yaml` does not appear to be used internally/externally anywhere. 3) If there were users of this functionality, it would have been already know, reported and fixed at this moment. The best course of action is fixing the test case by listing the `Time` as valid class for parsing. Fixes apjanke#80 [1]: https://docs.ruby-lang.org/en/master/Psych.html#method-c-safe_load [2]: yaml/yaml-spec#268
voxik
force-pushed
the
yaml-load-permit-time
branch
from
4bc23da to
25158fa
Compare
|
Ok, now how to make this compatible with old Rubies 🤔 |
This is due to Ruby 3.1 + Psych 4.0 changed changed `YAML.load` to use `safe_load` by default.
voxik
force-pushed
the
yaml-load-permit-time
branch
2 times, most recently
from
16a5bdb to
78249ea
Compare
This is to make the test case less poluted. Can be dropped once only Ruby 3.1+ is supported.
This should make Rubocop happy.
voxik
force-pushed
the
yaml-load-permit-time
branch
from
78249ea to
7c49ae1
Compare
|
Ok, so finally, the test suite is passing on CI for Ruby 2.7. The older Rubies fails due to some issues installing Nokogiri. The test matrix would certainly deserve some refresh. The PR ATM consists of 4 commits as the PR evolved. They could be squashed. Or the patch with extracted |
|
Fixed in e194bf6, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Psych 4.0, the
safe_loadis used as default loading mechanism. There are just a few permitted classes andTimeis not one of them [1]. This results it test failure:Please also note that in YAML specs 1.2, the
timestampis not listed as supported tag anymore [2].Given that:
to_yamldoes not appear to be used internally/externally anywhere.The best course of action is fixing the test case by listing the
Timeas valid class for parsing.Fixes #80