Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] require fileutils explicitly #125

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

mtasaka
Copy link
Contributor

@mtasaka mtasaka commented Nov 19, 2024

ruby 3.4 no longer loads fileutils implicitly.
Fixes #124 .

@apjanke
Copy link
Owner

apjanke commented Dec 2, 2024

Interesting. Is there any documentation on Ruby 3.4 no longer loading fileutils implicitly? I went googling and can't find any. I don't have a local Ruby 3.4 test environment set up yet; hopefully later today.

I'm inclined to just merge this even if that change isn't documented, because I don't see a downside, and the tests are passing. (The one failure is an unrelated rubocop complaint, shown here.)

image

.
.
image

@apjanke apjanke added this to the 0.10.2 milestone Dec 2, 2024
@apjanke apjanke self-assigned this Dec 2, 2024
@apjanke apjanke added the bug Something isn't working label Dec 2, 2024
@apjanke
Copy link
Owner

apjanke commented Dec 2, 2024

If you rebase on main, I think that'll clear up the "failing checks" issue. I think it's just a rubocop complaint that has been fixed on main.

ruby 3.4 no longer loads fileutils implicitly.
Fixes apjanke#124 .
@mtasaka
Copy link
Contributor Author

mtasaka commented Dec 4, 2024

(Just noting that I've rebased the patch)

@apjanke
Copy link
Owner

apjanke commented Dec 7, 2024

All checks pass after the rebase, and this looks good to me. Merged.

@apjanke apjanke merged commit 1448181 into apjanke:main Dec 7, 2024
11 checks passed
@apjanke
Copy link
Owner

apjanke commented Dec 7, 2024

Do you need me to make a new ronn-ng release to make this fix available to you, or is having it on the main branch good enough for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

testsuite errors with ruby3.4.0dev
2 participants