scrutinizer fixes

apix · Sep 29, 2014 · c99f00a · c99f00a
1 parent d4a7c7f
commit c99f00a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/src/Logger.php b/src/Logger.php
@@ -92,9 +92,9 @@ public function getFirstLoggerIndex($code)
     }
 
     /**
-     * Gets the name of the logging level (obsolete).
+     * Gets the name of the PSR-3 logging level.
      *
-     * @param  integer                  $level
+     * @param  string                   $level
      * @return string
      * @throws InvalidArgumentException
      */

diff --git a/src/Logger/AbstractLogger.php b/src/Logger/AbstractLogger.php
@@ -52,7 +52,7 @@ abstract class AbstractLogger extends AbsPsrLogger
     /**
      * Gets the named level code.
      *
-     * @return string $name
+     * @return string                   $name
      * @throws InvalidArgumentException
      */
     public static function getLevelCode($name)
@@ -104,9 +104,9 @@ public function process(array $log)
     }
 
     /**
-     * Checks whether the given level code will be handled by this handler.
+     * Checks whether the given level code is handled by this handler.
      *
-     * @param  integer $record
+     * @param  integer $level_code
      * @return boolean
      */
     public function isHandling($level_code)
@@ -123,7 +123,7 @@ public function isHandling($level_code)
      */
     public function setMinLevel($name)
     {
-        $this->min_level = static::getLevelCode($name);
+        $this->min_level = (int) static::getLevelCode($name);
 
         return $this;
     }

diff --git a/src/Logger/ErrorLog.php b/src/Logger/ErrorLog.php
@@ -50,7 +50,7 @@ class ErrorLog extends AbstractLogger implements LoggerInterface
     /**
      * Constructor.
      * @param string|null $file The filename to log messages to.
-     * @param string      $type The messag/delivery type.
+     * @param integer     $type The messag/delivery type.
      */
     public function __construct($file = null, $type = self::PHP)
     {

diff --git a/src/Logger/Mail.php b/src/Logger/Mail.php
@@ -25,9 +25,8 @@ class Mail extends ErrorLog implements LoggerInterface
     /**
      * Constructor.
      *
-     * @param  string                           $Email   Email addr to append to.
+     * @param  string                           $email   The email to append to.
      * @param  string|null                      $headers A string of additional (mail) headers.
-     * @see http://php.net/manual/en/function.mail.php
      * @throws Psr\Log\InvalidArgumentException If the email does not validate.
      */
     public function __construct($email, $headers = null)