Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grammar in FIREWALL.md #65

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix grammar in FIREWALL.md #65

merged 1 commit into from
Oct 16, 2024

Conversation

ronindesign
Copy link
Contributor

Screenshot 2024-10-16 at 12 37 10 PM

msaladna
msaladna approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@msaladna msaladna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The English language is not yet ready for double prepositions...

@msaladna msaladna closed this Oct 16, 2024
@ronindesign
Copy link
Contributor Author

Sorry, little confused. Looks like you approved, but closed this PR instead of merging?

Just want to make sure I'm following the correct contributing process.

As usual, thanks for all you do with ApisCP!

@msaladna msaladna reopened this Oct 16, 2024
@msaladna msaladna merged commit bbeb76f into apisnetworks:master Oct 16, 2024
@msaladna
Copy link
Member

You're correct. Rebased and merged.

@mfreeman451
Copy link

Whitelist?

@ronindesign ronindesign deleted the patch-2 branch October 17, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaladna msaladna msaladna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronindesign @msaladna @mfreeman451