indexer: add vcr integration with vitest #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaipaljadeja
force-pushed
the
feat/vcr-vitest
branch
from
fe34972 to
d25cbeb
Compare
jaipaljadeja
changed the title
jaipaljadeja
force-pushed
the
feat/vcr-vitest
branch
from
d25cbeb to
add7d95
Compare
fracek
requested changes
Jun 19, 2024
packages/indexer/package.json
Outdated
| @@ -29,6 +29,11 @@ | |||
| "types": "./dist/sinks/csv.d.ts", | |||
| "import": "./dist/sinks/csv.mjs", | |||
| "default": "./dist/sinks/csv.mjs" | |||
| }, | |||
| "./sinks/vcr": { | |||
There was a problem hiding this comment.
Need to add the export to the "exports" section abev too.
packages/indexer/src/tests/index.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export * from "./setup"; | |||
There was a problem hiding this comment.
Rename the folder to testing, then export it from package.json as ./testing. That way users will be able to import the functions as @apibara/indexer/testing.
packages/indexer/src/sinks/vcr.ts
Outdated
| @@ -0,0 +1,16 @@ | |||
| import { Sink, type SinkWriteArgs } from "../sink"; | |||
There was a problem hiding this comment.
This sink should be in the testing module since it's never used outside of testing.
jaipaljadeja
force-pushed
the
feat/vcr-vitest
branch
from
add7d95 to
be3f207
Compare
jaipaljadeja
force-pushed
the
feat/vcr-vitest
branch
from
eede9e6 to
19bf58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extends
vitestcontext withvcrallowing user to use recorded streams for writing tests.