-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protocol with index in transaction fields #136
Conversation
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 buf (1.47.2)packages/evm/proto/data.protoConfig file YAML parsing error: yaml: unmarshal errors: packages/starknet/proto/data.protoConfig file YAML parsing error: yaml: unmarshal errors: 📝 WalkthroughWalkthroughThis pull request introduces index tracking for events and logs across both Ethereum (EVM) and Starknet protocols. The changes add new optional fields to represent the index of logs, events, and messages within their respective transactions. These modifications enhance the granularity of transaction-related data structures in the Apibara libraries, allowing for more precise tracking of event and log positions during transaction processing. Changes
Sequence DiagramsequenceDiagram
participant Transaction
participant Log/Event
Transaction->>Log/Event: Assign Index
Log/Event-->>Transaction: Store Index
Note over Log/Event: logIndexInTransaction
Note over Log/Event: eventIndexInTransaction
Note over Log/Event: messageIndexInTransaction
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
✅ Files skipped from review due to trivial changes (2)
👮 Files not reviewed due to content moderation or server errors (4)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This PR adds the
{event,message,log}IndexInTransaction
fields to track the index inside a transaction.