Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): EventServiceProvider don't get registered correctly #217

Conversation

Mohammad-Alavi
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Mohammad-Alavi Mohammad-Alavi added the type: fix A correction or resolution to an identified issue label Dec 13, 2024
@Mohammad-Alavi Mohammad-Alavi self-assigned this Dec 13, 2024
@Mohammad-Alavi Mohammad-Alavi merged commit 3967f60 into 8.x Dec 13, 2024
3 checks passed
@Mohammad-Alavi Mohammad-Alavi deleted the API-1048-EventServiceProvider-won-t-get-registered-in-MainServiceProvider branch December 13, 2024 20:32
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 4.04%. Comparing base (e20b4b4) to head (dd33af4).
Report is 2 commits behind head on 8.x.

Files with missing lines Patch % Lines
src/Generator/Commands/ContainerApiGenerator.php 0.00% 15 Missing ⚠️
...rc/Generator/Commands/ServiceProviderGenerator.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               8.x    #217      +/-   ##
==========================================
- Coverage     4.05%   4.04%   -0.02%     
  Complexity     688     688              
==========================================
  Files           93      93              
  Lines         2886    2896      +10     
==========================================
  Hits           117     117              
- Misses        2769    2779      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix A correction or resolution to an identified issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant