Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests are generated in wrong directory #215

Merged

Conversation

Mohammad-Alavi
Copy link
Member

@Mohammad-Alavi Mohammad-Alavi commented Dec 13, 2024

Description

Functional tests are generated in the wrong directory. So they wont run if we try to run all tests using phpunit.xlm config.
This happened becasue @Mohammad-Alavi updated the test directory structure but forgot to update the code generator.
This PR fixed that problem and also update some test stubs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Mohammad-Alavi Mohammad-Alavi added type: enhancement A proposed improvement or addition to existing features type: fix A correction or resolution to an identified issue type: refactor Indicates that the issue or PR involves code restructuring without changing its external behavior labels Dec 13, 2024
@Mohammad-Alavi Mohammad-Alavi self-assigned this Dec 13, 2024
@Mohammad-Alavi Mohammad-Alavi merged commit a634f3a into 8.x Dec 13, 2024
@Mohammad-Alavi Mohammad-Alavi deleted the API-1169-Tests-are-generated-in-the-wrong-directory branch December 13, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A proposed improvement or addition to existing features type: fix A correction or resolution to an identified issue type: refactor Indicates that the issue or PR involves code restructuring without changing its external behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant