Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): Broken multi-action Controller generator #214

Merged

Conversation

Mohammad-Alavi
Copy link
Member

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (refactoring a current feature, method, etc...)
  • Code Coverage (adding/removing/updating/refactoring tests)
  • New feature (non-breaking change which adds functionality)
  • Remove feature (non-breaking change which removes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@Mohammad-Alavi Mohammad-Alavi added the type: fix A correction or resolution to an identified issue label Dec 8, 2024
@Mohammad-Alavi Mohammad-Alavi self-assigned this Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 4.25%. Comparing base (41af64d) to head (52f567d).
Report is 2 commits behind head on 8.x.

Files with missing lines Patch % Lines
src/Generator/Commands/RouteGenerator.php 0.00% 9 Missing ⚠️
src/Generator/Commands/ContainerApiGenerator.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               8.x    #214      +/-   ##
==========================================
- Coverage     4.26%   4.25%   -0.01%     
- Complexity     668     670       +2     
==========================================
  Files           92      92              
  Lines         2746    2751       +5     
==========================================
  Hits           117     117              
- Misses        2629    2634       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mohammad-Alavi Mohammad-Alavi merged commit a246d55 into 8.x Dec 8, 2024
3 of 5 checks passed
@Mohammad-Alavi Mohammad-Alavi deleted the API-1026-Broken-multi-action-Controller-generator branch December 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix A correction or resolution to an identified issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant