Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clarify 18 decimals for readDataFeed() #685

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

dcroote
Copy link
Collaborator

@dcroote dcroote commented Dec 17, 2023

See the discussion here and question on Discord.

@dcroote dcroote requested a review from wkande December 17, 2023 21:36
@dcroote dcroote self-assigned this Dec 17, 2023
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 7d4cd1d):

https://vitepress-docs--pr685-dcroote-dapi-decimal-rjrm6lp9.web.app

(expires Sun, 24 Dec 2023 21:37:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e4c5db1acb62b36273dc03718b86834917dea599

Copy link
Member

@wkande wkande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcroote dcroote merged commit 1e357c0 into main Dec 17, 2023
2 checks passed
@dcroote dcroote deleted the dcroote/dapi-decimals branch December 17, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants