Storebindings #19
Open
Storebindings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniogarrote
requested changes
Sep 3, 2020
| "@api-modeling/api-modeling-metadata": "^0.1.3", | ||
| "@api-modeling/amf-client-js": "^4.1.12", | ||
| "@api-modeling/api-modeling-metadata": "^0.1.4", | ||
| "@api-modeling/metadata-store": "^0.1.17", |
There was a problem hiding this comment.
Model-bindings cannot depend on the metadata-store
| @@ -13,7 +13,7 @@ import {ApiGenerator} from "./utils/apiGenerator"; | |||
| const SUPPORTED_FORMATS = [ApiParser.RAML1, ApiParser.OAS3 + ".0", ApiParser.OAS2, ApiParser.AMF_GRAPH, ApiParser.JSON_SCHEMA]; | |||
| const SUPPORTED_SYNTAXES = [ApiParser.YAML, ApiParser.JSONLD, ApiParser.JSON] | |||
|
|
|||
| export class APIContractBindingsPlugin extends BindingsPlugin { | |||
| export class APIContractBindingsPlugin /* extends BindingsPlugin */{ | |||
There was a problem hiding this comment.
We need to extend BindignsPlugin
|
|
||
| /** | ||
| * Some external resource plugins will work with. Just a URL identifying the resource and the text of the resource. | ||
| */ | ||
| export interface Resource { | ||
| url: string | ||
| text: string | ||
| text?: string |
There was a problem hiding this comment.
How can you get or generate a resource without data?
| /** | ||
| * Common interface for all bindings plugins | ||
| */ | ||
| export abstract class BindingsPlugin { | ||
| constructor(){} |
src/main/bindings/BindingsPlugin.ts
Outdated
| let graph = namedNode(regime) | ||
| let bindingDeclarationSource = namedNode(bindingDeclSrc) | ||
| let stupid = `file://${process.cwd()}/node_modules/@api-modeling/api-modeling-metadata/model/bindings/schema/modelBindingsDialect.yaml#/declarations/Binding` | ||
| store.addQuad(bindNode, rdfType, bindName,graph) |
There was a problem hiding this comment.
Why are we adding this to the store? If you generate bindings, add them to a bindings model
| return []; | ||
| } | ||
| } | ||
| export function findPathOld(store: n3.Store, subject: n3.Quad_Object, path: n3.Quad_Object[]): n3.Quad_Object|null { |
There was a problem hiding this comment.
Is this still in use? Remove if not
src/main/index.ts
Outdated
| @@ -0,0 +1,262 @@ | |||
| import {DialectWrapper, ModularityDialect, Module, Entity, Attribute, Association, IntegerScalar, StringScalar, DataModel, DataModelDialect, ModelBindingsDialect, BindingsModel, Binding, BindingArrayValue} from "@api-modeling/api-modeling-metadata"; | |||
There was a problem hiding this comment.
Why is this file here?
| @@ -1,95 +0,0 @@ | |||
| import { describe } from 'mocha' | |||
There was a problem hiding this comment.
Why is this removed?
…atenating entity group name and entity name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support full import and export. Works for CIM (almost). Added PluginController class to choose between multiple plugins. Should be easily called from the UI. There is still a minor issue with cim version.