Skip to content

Commit

Permalink
fix: adjustments to the websocket config message
Browse files Browse the repository at this point in the history
Signed-off-by: Christian Stewart <[email protected]>
  • Loading branch information
paralin committed Jun 21, 2024
1 parent 1deb7c0 commit b4ba3d1
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 14 deletions.
4 changes: 2 additions & 2 deletions transport/websocket/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const ConfigID = ControllerID
// This is a cursory validation to see if the values "look correct."
func (c *Config) Validate() error {
if _, err := c.ParseTransportPeerID(); err != nil {
return errors.Wrap(err, "node_peer_id")
return errors.Wrap(err, "transport_peer_id")
}
return nil
}
Expand All @@ -33,7 +33,7 @@ func (c *Config) GetConfigID() string {

// EqualsConfig checks if the other config is equal.
func (c *Config) EqualsConfig(c2 config.Config) bool {
return config.EqualsConfig[*Config](c, c2)
return config.EqualsConfig(c, c2)
}

// SetTransportPeerId sets the node peer ID field.
Expand Down
6 changes: 2 additions & 4 deletions transport/websocket/websocket.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions transport/websocket/websocket.pb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@ export const protobufPackage = 'websocket'
/**
* Config is the configuration for the Websocket transport.
*
* Bifrost speaks Quic over the websocket. While this is not always necessary,
* especially when using wss transports, we still need to ensure end-to-end
* encryption to the peer that we handshake with on the other end, and to manage
* stream congestion control, multiplexing,
* Quic is used for mTLS mutual authentication over the Websocket, as well as
* congestion control, stream multiplexing, and other performance features.
*
* @generated from message websocket.Config
*/
Expand Down
6 changes: 2 additions & 4 deletions transport/websocket/websocket.proto
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import "github.com/aperturerobotics/bifrost/transport/common/dialer/dialer.proto

// Config is the configuration for the Websocket transport.
//
// Bifrost speaks Quic over the websocket. While this is not always necessary,
// especially when using wss transports, we still need to ensure end-to-end
// encryption to the peer that we handshake with on the other end, and to manage
// stream congestion control, multiplexing,
// Quic is used for mTLS mutual authentication over the Websocket, as well as
// congestion control, stream multiplexing, and other performance features.
message Config {
// TransportPeerID sets the peer ID to attach the transport to.
// If unset, attaches to any running peer with a private key.
Expand Down

0 comments on commit b4ba3d1

Please sign in to comment.