Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GNOME 42. #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for GNOME 42. #8

wants to merge 3 commits into from

Conversation

Lashriel
Copy link

@Lashriel Lashriel commented May 12, 2022

This pull request adds version 42 to metadata.json and rewrites a small part of the extension in order to not throw an error on GNOME 42. Fixes issue #7 .

Tested working on an Acer ConceptD Ezel CC314-72G.

@Lashriel
Copy link
Author

Credit to @shyzus for the workaround on extension.json.

@strzinek
Copy link

This fix does not work for me on Fedora 36 with Gnome 42. The screen does seem to get rotated first, but keyboard and mouse stop working, making the Gnome unusable.

@Lashriel
Copy link
Author

Lashriel commented May 16, 2022

This fix does not work for me on Fedora 36 with Gnome 42. The screen does seem to get rotated first, but keyboard and mouse stop working, making the Gnome unusable.

I think this doesn't have to do with the fix applied in this pull-request, as I didn't touch anything related to tablet mode or even changed the operation of the extension all that much (It's pretty much just a try/catch applied around one bit of code that was error'ing out).

I think your device switches to Tablet Mode through its gyroscope, but then maybe it doesn't switch back when the screen is rotated back to normal, which would be a separate issue (and I'm not sure this extension is to blame).

When you lose keyboard and mouse input, try using the touchscreen to select a text field (the Search bar in the Activities overview will work fine) - if an on-screen keyboard pops up, it's in Tablet Mode.

@strzinek
Copy link

When the patched extension is active, the screen actually rotates, but neither mouse, keyboard nor touch is working. Mouse cursor shows on and moves, but mouse cursor does not get rotated with screen and no mouse buttons work. Besides that, desktop background image is shown only partially when in portrait mode.

@Lashriel
Copy link
Author

Lashriel commented May 16, 2022

When the patched extension is active, the screen actually rotates, but neither mouse, keyboard nor touch is working. Mouse cursor shows on and moves, but mouse cursor does not get rotated with screen and no mouse buttons work. Besides that, desktop background image is shown only partially when in portrait mode.

I assume you have all those inputs before the screen rotates?

If so, can you do me a favor and enable Looking Glass (alt+f2, then type "lg" in the prompt that shows up)
, select "extensions", and press "Show Errors" on the Screen Autorotate extension, then rotate the screen?

Because I can't reproduce the error on my end, so that's the only way I can think of to see if anything is error'ing out in the extension.

The background thing is most likely due to the wallpaper being set to "Zoom" which causes it to zoom in on a section of wallpaper (as opposed to stretching it across the screen). Set that to "Stretch" or "Span" and it should show your wallpaper normally while rotated.

EDIT: Hmm. I just tried again on Xorg and it does seem to "freeze" input for a few seconds every time I rotate on there - but given that information, I seriously think it's an entirely separate issue. Please file a separate bug report.

@DasJott
Copy link

DasJott commented May 30, 2022

Works for me. Just tested it with Fedora 36 - made the changes manually.
Simply works, except the mouse direction is not changing but I don't remember whether or not it worked before.

For a quick fix I would highly recommend to accept this request as it makes it work again.

@RoepLuke
Copy link

RoepLuke commented Jun 1, 2022

This fix works flawlessly for me on Fedora 36 (wayland) on an HP Envy x360. No lag and keyboard, mouse and touch work without a problem. Thank you for the fix!

@rikozeta
Copy link

It works fine in Manjaro, wayland & xorg, on a HP Spectre x360. Thanxs!

@AlecWaichunas
Copy link

This fix worked for me as well in Arch, wayland, on a Lenovo ideapad Flex 5. Thanks!

@seltzered
Copy link

This PR worked as well for me on Ubuntu 22.04 (wayland) on an HP tablet, thanks! @kosmospredanie any plans to make a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants